netdev - Re: [EXT] Re: [PATCH net-next 01/10] net: atlantic: media detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4870c58-14ff-cb30-c793-f577b02336c1@marvell.com>
Date:   Wed, 15 Jul 2020 10:41:53 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        "Mark Starovoytov" <mstarovoitov@...vell.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [EXT] Re: [PATCH net-next 01/10] net: atlantic: media detect


> On Mon, Jul 13, 2020 at 02:42:24PM +0300, Igor Russkikh wrote:
>> This patch adds support for low-power autoneg in PHY (media detect).
>> This is a custom feature of AQC107 builtin PHY, but configuration is
> only
>> done through MAC management firmware.
> 
> Hi Igor
> 
> Do the standalone PHYs also support this? It would be nice to have the
> same user space API for both.
> 
> There is no reason why phy tuneables cannot be implemented by the MAC
> driver. It just needs another ethtool op and some plumbing in
> net/ethtool. That would give a more uniform solution.

Hi Andrew,

Unfortunately I can't verify this on standalone PHY, but some models similar
to what in AQC107 in theory should.

Whats your opinion then? Add this feature with phy tunable with ability to
handle in netdev driver?

Thanks,
  Igor