netdev - Re: [PATCH net-next 06/10] net: atlantic: add support for 64-bit reads/writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713150724.2e57e905@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 13 Jul 2020 15:07:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Pavel Belous <pbelous@...vell.com>
Subject: Re: [PATCH net-next 06/10] net: atlantic: add support for 64-bit
 reads/writes

On Mon, 13 Jul 2020 14:42:29 +0300 Igor Russkikh wrote:
> +#ifdef CONFIG_X86_64
> +	if (hw->aq_nic_cfg->aq_hw_caps->op64bit)
> +		value = readq(hw->mmio + reg);
> +	else
> +#endif
> +	{
> +		value = aq_hw_read_reg(hw, reg);
> +		value |= (u64)aq_hw_read_reg(hw, reg + 4) << 32;
> +	}

I think you just need to include something like:

#include <linux/io-64-nonatomic-lo-hi.h>

You seem to always access the lower half first.