netdev - Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 08:20:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang Hai <wanghai38@...wei.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Wang Hai <wanghai26@...wei.com>,
        Shannon Nelson <snelson@...sando.io>,
        Nicolas Pitre <nico@...xnic.net>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev)
> should be called to free the ndev created earlier. Otherwise, a memleak
> will occur.

* Will it be nicer to use the term “memory leak” also in this change description?

* Would another imperative wording be preferred for the commit message?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f8456690ba8eb18ea4714e68554e242a04f65cff#n151

Regards,
Markus