netdev - Re: [PATCH ipsec-next 0/3] xfrm: not register one xfrm(6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200716063227.GW20687@gauss3.secunet.de>
Date:   Thu, 16 Jul 2020 08:32:27 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
        "Sabrina Dubroca" <sd@...asysnail.net>
Subject: Re: [PATCH ipsec-next 0/3] xfrm: not register one xfrm(6)_tunnel
 object twice

On Mon, Jul 13, 2020 at 03:42:35PM +0800, Xin Long wrote:
> Now in ip(6)_vti and xfrm interface tunnel support, it uses the
> same xfrm(6)_tunnel object to handle for AF_NET and AF_INET6 by
> registering it twice.
> 
> However the xfrm(6)_tunnel object is linked into a list with its
> 'next' pointer. The second registering will cause its 'next'
> pointer to be overwritten, and break the list.
> 
> So this patchset is to add a new xfrm(6)_tunnel object for each
> of them and register it, although its members are the same with
> the old one.
> 
> Xin Long (3):
>   ip_vti: not register vti_ipip_handler twice
>   ip6_vti: not register vti_ipv6_handler twice
>   xfrm: interface: not xfrmi_ipv6/ipip_handler twice


Applied, thanks Xin!