netdev - Re: do a single memdup_user in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200719.182727.141244810520299886.davem@davemloft.net>
Date:   Sun, 19 Jul 2020 18:27:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hch@....de
Cc:     vyasevich@...il.com, nhorman@...driver.com,
        marcelo.leitner@...il.com, kuba@...nel.org,
        David.Laight@...LAB.COM, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: do a single memdup_user in sctp_setsockopt v2

From: Christoph Hellwig <hch@....de>
Date: Sun, 19 Jul 2020 09:21:37 +0200

> here is a resend of my series to lift the copy_from_user out of the
> individual sctp sockopt handlers into the main sctp_setsockopt
> routine.
> 
> Changes since v1:
>  - fixes a few sizeof calls.
>  - use memzero_explicit in sctp_setsockopt_auth_key instead of special
>    casing it for a kzfree in the caller
>  - remove some minor cleanups from sctp_setsockopt_autoclose to keep
>    it closer to the existing version
>  - add another little only vaguely related cleanup patch

This is all very mechanical and contained to the sockopt code of SCTP,
so I reviewed this a few times and applied it to net-next.

Thanks Christoph!