netdev - Re: do a single memdup_user in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200720130840.GB2491@localhost.localdomain>
Date:   Mon, 20 Jul 2020 10:08:40 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     hch@....de, vyasevich@...il.com, nhorman@...driver.com,
        kuba@...nel.org, David.Laight@...lab.com,
        linux-sctp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: do a single memdup_user in sctp_setsockopt v2

On Sun, Jul 19, 2020 at 06:27:27PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@....de>
> Date: Sun, 19 Jul 2020 09:21:37 +0200
> 
> > here is a resend of my series to lift the copy_from_user out of the
> > individual sctp sockopt handlers into the main sctp_setsockopt
> > routine.
> > 
> > Changes since v1:
> >  - fixes a few sizeof calls.
> >  - use memzero_explicit in sctp_setsockopt_auth_key instead of special
> >    casing it for a kzfree in the caller
> >  - remove some minor cleanups from sctp_setsockopt_autoclose to keep
> >    it closer to the existing version
> >  - add another little only vaguely related cleanup patch
> 
> This is all very mechanical and contained to the sockopt code of SCTP,
> so I reviewed this a few times and applied it to net-next.
> 
> Thanks Christoph!

Yep! And way easier to work with, function by function.

Just for the records,
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Thanks.