netdev - Re: [tipc-discussion] [net v1 1/1] tipc: allow to build NACK message in link timeout function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.201226.912664403829372463.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 20:12:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tung.q.nguyen@...tech.com.au
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [tipc-discussion] [net v1 1/1] tipc: allow to build NACK
 message in link timeout function

From: Tung Nguyen <tung.q.nguyen@...tech.com.au>
Date: Tue, 21 Jul 2020 08:57:05 +0700

> Commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages")
> eliminated sending of the 'gap' indicator in regular ACK messages and
> only allowed to build NACK message with enabled probe/probe_reply.
> However, necessary correction for building NACK message was missed
> in tipc_link_timeout() function. This leads to significant delay and
> link reset (due to retransmission failure) in lossy environment.
> 
> This commit fixes it by setting the 'probe' flag to 'true' when
> the receive deferred queue is not empty. As a result, NACK message
> will be built to send back to another peer.
> 
> Fixes: commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages")

"commit" doesn't belong here, I removed it when I applied your patch.

> Acked-by: Jon Maloy <jmaloy@...hat.com>
> Signed-off-by: Tung Nguyen <tung.q.nguyen@...tech.com.au>

Applied and queued up for -stable, thanks.