netdev - Re: [PATCH v4 net-next] net: hyperv: Add attributes to show TX indirection table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.201400.1580393372170110087.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 20:14:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Song.Chi@...rosoft.com
Cc:     haiyangz@...rosoft.com, kys@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, kuba@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net-next] net: hyperv: Add attributes to show TX
 indirection table

From: Chi Song <Song.Chi@...rosoft.com>
Date: Tue, 21 Jul 2020 02:37:42 +0000

> +static ssize_t tx_indirection_show(struct device *dev,
> +				   struct device_attribute *dev_attr, char *buf)
> +{
> +	struct net_device *ndev = to_net_dev(dev);
> +	struct net_device_context *ndc = netdev_priv(ndev);
> +	int index = dev_attr - dev_attr_netvsc_dev_attrs;

Reverse christmas tree ordering for local variables please.

> +static void netvsc_attrs_init(void)
> +{
> +	int i;
> +	char buffer[4];

Likewise.