netdev - Re: [PATCH ipsec-next] xfrm: interface: use IS_REACHABLE to avoid some compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200721060804.GI20687@gauss3.secunet.de>
Date:   Tue, 21 Jul 2020 08:08:04 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, kbuild test robot <lkp@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH ipsec-next] xfrm: interface: use IS_REACHABLE to avoid
 some compile errors

On Fri, Jul 17, 2020 at 03:02:30PM +0800, Xin Long wrote:
> kernel test robot reported some compile errors:
> 
>   ia64-linux-ld: net/xfrm/xfrm_interface.o: in function `xfrmi4_fini':
>   net/xfrm/xfrm_interface.c:900: undefined reference to `xfrm4_tunnel_deregister'
>   ia64-linux-ld: net/xfrm/xfrm_interface.c:901: undefined reference to `xfrm4_tunnel_deregister'
>   ia64-linux-ld: net/xfrm/xfrm_interface.o: in function `xfrmi4_init':
>   net/xfrm/xfrm_interface.c:873: undefined reference to `xfrm4_tunnel_register'
>   ia64-linux-ld: net/xfrm/xfrm_interface.c:876: undefined reference to `xfrm4_tunnel_register'
>   ia64-linux-ld: net/xfrm/xfrm_interface.c:885: undefined reference to `xfrm4_tunnel_deregister'
> 
> This happened when set CONFIG_XFRM_INTERFACE=y and CONFIG_INET_TUNNEL=m.
> We don't really want xfrm_interface to depend inet_tunnel completely,
> but only to disable the tunnel code when inet_tunnel is not seen.
> 
> So instead of adding "select INET_TUNNEL" for XFRM_INTERFACE, this patch
> is only to change to IS_REACHABLE to avoid these compile error.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: da9bbf0598c9 ("xfrm: interface: support IPIP and IPIP6 tunnels processing with .cb_handler")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks!