netdev - Re: [PATCH ipsec-next] ip6_vti: use IS_REACHABLE to avoid some compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200721060839.GJ20687@gauss3.secunet.de>
Date:   Tue, 21 Jul 2020 08:08:39 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
        "Naresh Kamboju" <naresh.kamboju@...aro.org>
Subject: Re: [PATCH ipsec-next] ip6_vti: use IS_REACHABLE to avoid some
 compile errors

On Fri, Jul 17, 2020 at 03:03:14PM +0800, Xin Long wrote:
> Naresh reported some compile errors:
> 
>   arm build failed due this error on linux-next 20200713 and  20200713
>   net/ipv6/ip6_vti.o: In function `vti6_rcv_tunnel':
>   ip6_vti.c:(.text+0x1d20): undefined reference to `xfrm6_tunnel_spi_lookup'
> 
> This happened when set CONFIG_IPV6_VTI=y and CONFIG_INET6_TUNNEL=m.
> We don't really want ip6_vti to depend inet6_tunnel completely, but
> only to disable the tunnel code when inet6_tunnel is not seen.
> 
> So instead of adding "select INET6_TUNNEL" for IPV6_VTI, this patch
> is only to change to IS_REACHABLE to avoid these compile error.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Fixes: 08622869ed3f ("ip6_vti: support IP6IP6 tunnel processing with .cb_handler")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Also applied, thanks a lot!