netdev - Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723100843.5c7dc128@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 23 Jul 2020 10:08:43 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Chi Song <chisong@...rosoft.com>
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 net-next] net: hyperv: dump TX indirection table to
 ethtool regs

On Wed, 22 Jul 2020 23:59:09 -0700 (PDT) Chi Song wrote:
> An imbalanced TX indirection table causes netvsc to have low
> performance. This table is created and managed during runtime. To help
> better diagnose performance issues caused by imbalanced tables, it needs
> make TX indirection tables visible.
> 
> Because TX indirection table is driver specified information, so
> display it via ethtool register dump.
> 
> Signed-off-by: Chi Song <chisong@...rosoft.com>

The patch looks good to me, but it has been corrupted by your email
client, could you perhaps try git send-email?

> +	memcpy(regs_buff, ndc->tx_table, VRSS_SEND_TAB_SIZE *
> sizeof(u32));