netdev - Re: [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp header parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jul 2020 10:11:50 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 2/2] net: dsa: mv88e6xxx: Use generic ptp header
 parsing function

On Thu, Jul 23, 2020 at 09:49:46AM +0200, Kurt Kanzenbach wrote:
> @@ -26,6 +26,7 @@ config NET_DSA_MV88E6XXX_PTP
>  	depends on NET_DSA_MV88E6XXX_GLOBAL2
>  	depends on PTP_1588_CLOCK
>  	imply NETWORK_PHY_TIMESTAMPING
> +	select NET_PTP_CLASSIFY

Hm, PTP_1588_CLOCK already selects NET_PTP_CLASSIFY,

  config PTP_1588_CLOCK
	tristate "PTP clock support"
	depends on NET && POSIX_TIMERS
	select PPS
	select NET_PTP_CLASSIFY

and so I expect that the 'select' in NET_DSA_MV88E6XXX_PTP isn't
needed.  What am I missing?

Thanks,
Richard