netdev - Re: [net-next 1/8] igc: Fix double definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be2fef6e6f07b3fea067a8fd71d8d25c01891fd9.camel@intel.com>
Date:   Thu, 23 Jul 2020 20:00:48 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "nhorman@...hat.com" <nhorman@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Neftin, Sasha" <sasha.neftin@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>
Subject: Re: [net-next 1/8] igc: Fix double definition

On Wed, 2020-07-22 at 15:48 -0700, Jakub Kicinski wrote:
> On Wed, 22 Jul 2020 14:31:43 -0700 Tony Nguyen wrote:
> > Accordance to the i225 specification address 0x4118 used for
> > Host Good Packet Transmitted Count and defined as read on clear.
> > IGC_ICTXQEC not in use and could be removed.
> 
> Not entirely sure what this commit message is trying to communicate.
> 
> Also it'd had been better if you removed the member of hw_stats
> structure in the same commit.

Thanks for the feedback. I'll work with Sasha to get this and the
feedback on the other patches addressed.

Thanks,
Tony