netdev - Re: [PATCH net-next v3 10/12] fm10k: convert to new udp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4563bd21-96c3-26da-4798-68820baf23eb@intel.com>
Date:   Wed, 22 Jul 2020 17:30:40 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        simon.horman@...ronome.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        thomas.lendacky@....com, aelior@...vell.com, skalluru@...vell.com,
        vishal@...lsio.com, benve@...co.com, _govind@....com,
        dchickles@...vell.com, sburla@...vell.com, fmanlunas@...vell.com,
        jeffrey.t.kirsher@...el.com, anthony.l.nguyen@...el.com,
        GR-everest-linux-l2@...vell.com, shshaikh@...vell.com,
        manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com
Subject: Re: [PATCH net-next v3 10/12] fm10k: convert to new udp_tunnel_nic
 infra



On 7/14/2020 12:18 PM, Jakub Kicinski wrote:
> Straightforward conversion to new infra. Driver restores info
> after close/open cycle by calling its internal restore function
> so just use that, no need for udp_tunnel_nic_reset_ntf() here.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Maybe late, but LGTM

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks for this type of cleanup, it's good to see it progressing!

-Jake