netdev - Re: [PATCH 2/2] appletalk: Improve handling of broadcast packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 17:31:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vincent.ldev@...ert.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] appletalk: Improve handling of broadcast packets

From: Vincent Duvert <vincent.ldev@...ert.net>
Date: Wed, 22 Jul 2020 13:37:52 +0200

> @@ -89,6 +89,7 @@ static struct sock *atalk_search_socket(struct sockaddr_at *to,
>  					struct atalk_iface *atif)
>  {
>  	struct sock *s;
> +	struct sock *def_socket = NULL;
>  
>  	read_lock_bh(&atalk_sockets_lock);
>  	sk_for_each(s, &atalk_sockets) {

Please use reverse christmas tree ordering for local variables.

Also, please post the next revision of this patch series with
a proper "[PATCH net 0/N]" header posting, explaining what the
patch series is doing, how it is doing it, and why it is
doing it this way.

Your Subject lines should all also indicate the proper target GIT tree
your changes are for.  This is indicated in the "[]" bracket area,
as either 'net' or 'net-next', f.e. "[PATCH net 1/2] ..."

Thank you.