netdev - Re: [PATCH net-next] enetc: Remove the imdio bus on PF probe bailout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200722.173233.132610667256223878.davem@davemloft.net>
Date:   Wed, 22 Jul 2020 17:32:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] enetc: Remove the imdio bus on PF probe
 bailout

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Wed, 22 Jul 2020 15:38:48 +0300

> enetc_imdio_remove() is missing from the enetc_pf_probe()
> bailout path. Not surprisingly because enetc_setup_serdes()
> is registering the imdio bus for internal purposes, and it's
> not obvious that enetc_imdio_remove() currently performs the
> teardown of enetc_setup_serdes().
> To fix this, define enetc_teardown_serdes() to wrap
> enetc_imdio_remove() (improve code maintenance) and call it
> on bailout and remove paths.
> 
> Fixes: 975d183ef0ca ("net: enetc: Initialize SerDes for SGMII and USXGMII protocols")
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied, thanks.