netdev - Re: [PATCH net] vrf: Handle CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95a112c8-8724-61eb-596b-de94969598cc@infradead.org>
Date:   Thu, 23 Jul 2020 17:28:54 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     Andrea Mayer <andrea.mayer@...roma2.it>
Subject: Re: [PATCH net] vrf: Handle CONFIG_SYSCTL not set

On 7/23/20 4:23 PM, David Ahern wrote:
> Randy reported compile failure when CONFIG_SYSCTL is not set/enabled:
> 
> ERROR: modpost: "sysctl_vals" [drivers/net/vrf.ko] undefined!
> 
> Fix by splitting out the sysctl init and cleanup into helpers that
> can be set to do nothing when CONFIG_SYSCTL is disabled. In addition,
> move vrf_strict_mode and vrf_strict_mode_change to above
> vrf_shared_table_handler (code move only) and wrap all of it
> in the ifdef CONFIG_SYSCTL.
> 
> Update the strict mode tests to check for the existence of the
> /proc/sys entry.
> 
> Fixes: 33306f1aaf82 ("vrf: add sysctl parameter for strict mode")
> Cc: Andrea Mayer <andrea.mayer@...roma2.it>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: David Ahern <dsahern@...nel.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.


> ---
>  drivers/net/vrf.c                             | 138 ++++++++++--------
>  .../selftests/net/vrf_strict_mode_test.sh     |   6 +
>  2 files changed, 83 insertions(+), 61 deletions(-)


-- 
~Randy