netdev - Re: [PATCH net] vrf: Handle CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200723.175125.1061358245366802716.davem@davemloft.net>
Date:   Thu, 23 Jul 2020 17:51:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, andrea.mayer@...roma2.it,
        rdunlap@...radead.org
Subject: Re: [PATCH net] vrf: Handle CONFIG_SYSCTL not set

From: David Ahern <dsahern@...nel.org>
Date: Thu, 23 Jul 2020 17:23:09 -0600

> Randy reported compile failure when CONFIG_SYSCTL is not set/enabled:
> 
> ERROR: modpost: "sysctl_vals" [drivers/net/vrf.ko] undefined!
> 
> Fix by splitting out the sysctl init and cleanup into helpers that
> can be set to do nothing when CONFIG_SYSCTL is disabled. In addition,
> move vrf_strict_mode and vrf_strict_mode_change to above
> vrf_shared_table_handler (code move only) and wrap all of it
> in the ifdef CONFIG_SYSCTL.
> 
> Update the strict mode tests to check for the existence of the
> /proc/sys entry.
> 
> Fixes: 33306f1aaf82 ("vrf: add sysctl parameter for strict mode")
> Cc: Andrea Mayer <andrea.mayer@...roma2.it>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: David Ahern <dsahern@...nel.org>

Applied to net-next, thanks David.