netdev - Re: [PATCH net 4/4] selftests/net: tcp_mmap: fix clang warning for target arch PowerPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09186bcf-eb8a-7424-6901-789914e61848@gmail.com>
Date:   Mon, 27 Jul 2020 12:33:59 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Tanner Love <tannerlove.kernel@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, Tanner Love <tannerlove@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net 4/4] selftests/net: tcp_mmap: fix clang warning for
 target arch PowerPC



On 7/27/20 9:25 AM, Tanner Love wrote:
> From: Tanner Love <tannerlove@...gle.com>
> 
> When size_t maps to unsigned int (e.g. on 32-bit powerpc), then the
> comparison with 1<<35 is always true. Clang 9 threw:
> warning: result of comparison of constant 34359738368 with \
> expression of type 'size_t' (aka 'unsigned int') is always true \
> [-Wtautological-constant-out-of-range-compare]
>         while (total < FILE_SZ) {
> 
> Tested: make -C tools/testing/selftests TARGETS="net" run_tests
> 
> Fixes: 192dc405f308 ("selftests: net: add tcp_mmap program")
> Signed-off-by: Tanner Love <tannerlove@...gle.com>
> Acked-by: Willem de Bruijn <willemb@...gle.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !