netdev - Re: [PATCH RFC net-next 1/2] xdp: helpers: add multibuffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200727.123553.1187716564951764887.davem@davemloft.net>
Date:   Mon, 27 Jul 2020 12:35:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sameehj@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        netanel@...zon.com, alisaidi@...zon.com, benh@...zon.com,
        akiyano@...zon.com, ndagan@...zon.com, ast@...nel.org,
        daniel@...earbox.net, kafai@...com, songliubraving@...com,
        yhs@...com, andriin@...com, john.fastabend@...il.com,
        kpsingh@...omium.org, kuba@...nel.org, hawk@...nel.org,
        shayagr@...zon.com, lorenzo@...nel.org
Subject: Re: [PATCH RFC net-next 1/2] xdp: helpers: add multibuffer support

From: <sameehj@...zon.com>
Date: Mon, 27 Jul 2020 12:56:52 +0000

> diff --git a/net/core/filter.c b/net/core/filter.c
> index bdd2382e6..93e790d7b 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -3452,6 +3452,62 @@ static const struct bpf_func_proto bpf_xdp_adjust_head_proto = {
>  	.arg2_type	= ARG_ANYTHING,
>  };
>  
> +static inline bool __bpf_xdp_has_frags(struct  xdp_buff *xdp)
> +{
> +	return xdp->mb != 0;
> +}

Please don't use the inline keyword in foo.c files, let the compiler decide.

Thank you.