netdev - Re: [PATCH net-next] rtnetlink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200727134703.4243db74@hermes.lan>
Date:   Mon, 27 Jul 2020 13:47:03 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason

On Mon, 27 Jul 2020 12:21:17 -0700
Roopa Prabhu <roopa@...ulusnetworks.com> wrote:

> -	       + nla_total_size(1)  /* IFLA_PROTO_DOWN */
> +	       + rtnl_proto_down_size(dev)  /* proto down */

Changing the size of a netlink field is an ABI change in the kernel.
This has the potential to break existing programs.

Wouldn't it be safer to add a new link attribute for the reason
rather than overloading the existing attribute?