netdev - Re: [PATCH net-next] rtnetlink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82245748-d0b6-92c7-bb43-b6d006795d74@nvidia.com>
Date:   Mon, 27 Jul 2020 15:43:33 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason


On 7/27/20 1:47 PM, Stephen Hemminger wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 27 Jul 2020 12:21:17 -0700
> Roopa Prabhu <roopa@...ulusnetworks.com> wrote:
>
>> -            + nla_total_size(1)  /* IFLA_PROTO_DOWN */
>> +            + rtnl_proto_down_size(dev)  /* proto down */
> Changing the size of a netlink field is an ABI change in the kernel.
> This has the potential to break existing programs.
>
> Wouldn't it be safer to add a new link attribute for the reason
> rather than overloading the existing attribute?


yes, It does add a new attribute. Its just that I moved all protodown 
attribute handling to a separate function