netdev - Re: [PATCH net-next] rtnetlink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Jul 2020 16:38:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Mon, 27 Jul 2020 12:21:17 -0700

> +/**
> + *	dev_get_proto_down_reason - returns protodown reason
> + *
> + *	@dev: device
> + */
> +u32 dev_get_proto_down_reason(const struct net_device *dev)
> +{
> +	return dev->proto_down_reason;
> +}
> +EXPORT_SYMBOL(dev_get_proto_down_reason);

This helper is excessive, please remove it and just dereference the
netdev member directly.

Thank you.