netdev - Re: [PATCH net-next] rtnetlink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <344b71b6-82f8-bc7a-235b-6b372415084a@nvidia.com>
Date:   Thu, 30 Jul 2020 19:59:06 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     David Miller <davem@...emloft.net>, <roopa@...ulusnetworks.com>
CC:     <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next] rtnetlink: add support for protodown reason


On 7/30/20 4:38 PM, David Miller wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> Date: Mon, 27 Jul 2020 12:21:17 -0700
>
>> +/**
>> + *   dev_get_proto_down_reason - returns protodown reason
>> + *
>> + *   @dev: device
>> + */
>> +u32 dev_get_proto_down_reason(const struct net_device *dev)
>> +{
>> +     return dev->proto_down_reason;
>> +}
>> +EXPORT_SYMBOL(dev_get_proto_down_reason);
> This helper is excessive, please remove it and just dereference the
> netdev member directly.
>
> Thank you.


agree, will send v2. (it was meant to do more than just that initially)