netdev - Re: [ethtool] ethtool: fix netlink bitmasks when sent as NOMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200727224001.hevbrhillv7tdmdo@lion.mk-sys.cz>
Date:   Tue, 28 Jul 2020 00:40:01 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jamie Gloudon <jamie.gloudon@....fr>
Subject: Re: [ethtool] ethtool: fix netlink bitmasks when sent as NOMASK

On Mon, Jul 27, 2020 at 10:32:03PM +0000, Keller, Jacob E wrote:
> > -----Original Message-----
> > From: Michal Kubecek <mkubecek@...e.cz>
> > Sent: Monday, July 27, 2020 3:27 PM
> > To: Andrew Lunn <andrew@...n.ch>
> > Cc: Keller, Jacob E <jacob.e.keller@...el.com>; netdev@...r.kernel.org; Jamie
> > Gloudon <jamie.gloudon@....fr>
> > Subject: Re: [ethtool] ethtool: fix netlink bitmasks when sent as NOMASK
> > 
> > On Tue, Jul 28, 2020 at 12:11:04AM +0200, Andrew Lunn wrote:
> > > Hi Jacob
> > >
> > > This is close
> > >
> > > Netlink
> > > 	Link partner advertised link modes:  10baseT/Half 10baseT/Full
> > > 	                                     100baseT/Half 100baseT/Full
> > > 	                                     1000baseT/Full
> > > 	Link partner advertised pause frame use: No
> > > 	Link partner advertised auto-negotiation: Yes
> > > 	Link partner advertised FEC modes: No
> > >
> > > IOCTL
> > > 	Link partner advertised link modes:  10baseT/Half 10baseT/Full
> > > 	                                     100baseT/Half 100baseT/Full
> > > 	                                     1000baseT/Full
> > > 	Link partner advertised pause frame use: No
> > > 	Link partner advertised auto-negotiation: Yes
> > > 	Link partner advertised FEC modes: Not reported
> > >
> > > So just the FEC modes differ.
> > 
> > This is a different issue, the last call to dump_link_modes() in
> > dump_peer_modes() should be
> > 
> > 	ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC,
> > 
> > (third parameter needs to be false, not true).
> > 
> > Michal
> > 
> 
> That's part of it, yea, but also it should use the string "Not
> Reported" instead of "No" I think?

Right, both should be fixed.

Michal

> 
> > >
> > > However, i don't think this was part of the original issue, so:
> > >
> > > Tested-by: Andrew Lunn <andrew@...n.ch>
> > >
> > > It would be nice to get the FEC modes fixed.
> > >
> > >     Andrew