netdev - Re: [Patch net-next] net_sched: initialize timer earlier in red

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200728.174154.77325504094188897.davem@davemloft.net>
Date:   Tue, 28 Jul 2020 17:41:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+6e95a4fabf88dc217145@...kaller.appspotmail.com,
        petrm@...lanox.com, jhs@...atatu.com, jiri@...nulli.us
Subject: Re: [Patch net-next] net_sched: initialize timer earlier in
 red_init()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sat, 25 Jul 2020 13:17:07 -0700

> When red_init() fails, red_destroy() is called to clean up.
> If the timer is not initialized yet, del_timer_sync() will
> complain. So we have to move timer_setup() before any failure.
> 
> Reported-and-tested-by: syzbot+6e95a4fabf88dc217145@...kaller.appspotmail.com
> Fixes: aee9caa03fc3 ("net: sched: sch_red: Add qevents "early_drop" and "mark"")
> Cc: Petr Machata <petrm@...lanox.com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thank you.