netdev - Re: [PATCH 4/4] net: improve the user pointer check in init_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jul 2020 08:04:01 +0200
From:   Christoph Hellwig <hch@....de>
To:     David Miller <davem@...emloft.net>
Cc:     hch@....de, jengelh@...i.de, idosch@...sch.org, Jason@...c4.com,
        David.Laight@...LAB.COM, netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] net: improve the user pointer check in
 init_user_sockptr

On Tue, Jul 28, 2020 at 01:01:11PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@....de>
> Date: Tue, 28 Jul 2020 08:36:43 +0200
> 
> >  	if (get_user(len, optlen))
> >  		return -EFAULT;
>         ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > -	err = init_user_sockptr(&optval, user_optval);
> > +	err = init_user_sockptr(&optval, user_optval, *optlen);
>                                                       ^^^^^^^^
> 
> Hmmm?

A fixed version was already posted yesterday:

https://lore.kernel.org/netdev/20200728163836.562074-1-hch@lst.de/T/#me3e9c7b71e39b4689628ed2e61dec06705344847