netdev - Re: [PATCH 4/4] net: improve the user pointer check in init_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200728.130111.2163106097158516623.davem@davemloft.net>
Date:   Tue, 28 Jul 2020 13:01:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hch@....de
Cc:     jengelh@...i.de, idosch@...sch.org, Jason@...c4.com,
        David.Laight@...LAB.COM, netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] net: improve the user pointer check in
 init_user_sockptr

From: Christoph Hellwig <hch@....de>
Date: Tue, 28 Jul 2020 08:36:43 +0200

>  	if (get_user(len, optlen))
>  		return -EFAULT;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
> -	err = init_user_sockptr(&optval, user_optval);
> +	err = init_user_sockptr(&optval, user_optval, *optlen);
                                                      ^^^^^^^^

Hmmm?