netdev - Re: [PATCH 4/4] net: improve the user pointer check in init_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200728115325.353c3028@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 28 Jul 2020 11:53:25 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jan Engelhardt <jengelh@...i.de>,
        Ido Schimmel <idosch@...sch.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        David Laight <David.Laight@...LAB.COM>, netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] net: improve the user pointer check in
 init_user_sockptr

On Tue, 28 Jul 2020 17:51:40 +0200 Christoph Hellwig wrote:
> On Tue, Jul 28, 2020 at 08:47:46AM -0700, Jakub Kicinski wrote:
> > Appears to cause these two new warnings, sadly:
> > 
> > net/ipv4/bpfilter/sockopt.c:68:56: warning: dereference of noderef expression
> > net/ipv4/bpfilter/sockopt.c:68:56: warning: dereference of noderef expression  
> 
> Shouldn't this just be one?  That one is justified, though as *optlen
> should be len.

Could be, seems like sparse duplicates some warnings in my build system,
not sure why :S