netdev - 答复: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Jul 2020 01:15:08 +0000
From:   "Li,Rongqing" <lirongqing@...du.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Tony Nguyen <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: 答复: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally



> -----邮件原件-----
> 发件人: Jakub Kicinski [mailto:kuba@...nel.org]
> 发送时间: 2020年7月30日 5:20
> 收件人: Li,Rongqing <lirongqing@...du.com>
> 抄送: Tony Nguyen <anthony.l.nguyen@...el.com>; davem@...emloft.net;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> jeffrey.t.kirsher@...el.com; Andrew Bowers <andrewx.bowers@...el.com>
> 主题: Re: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally
> 
> On Wed, 29 Jul 2020 06:20:47 +0000 Li,Rongqing wrote:
> > > Looks like something that belongs in a common header not
> > > (potentially
> > > multiple) C sources.
> >
> > Not clear, how should I change?
> 
> Can you add something like:
> 
> static inline void prefetch_page_address(struct page *page) { #if
> defined(WANT_PAGE_VIRTUAL) || defined(HASHED_PAGE_VIRTUAL)
> 	prefetch(page);
> #endif
> }
> 
> to mm.h or prefetch.h or i40e.h or some other header? That's preferred over
> adding #ifs directly in the source code.


Thanks, I will send a new version

-Li