netdev - Re: [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNjBCNcb+KO+V0hmSvo2i5L+Cf52F3=-+7TonXkGJ9dXgA@mail.gmail.com>
Date:   Mon, 10 Aug 2020 13:47:45 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, nhorman@...hat.com,
        sassmann@...hat.com, Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [net-next 0/6][pull request] 40GbE Intel Wired LAN Driver Updates 2020-07-28

On Tue, 28 Jul 2020 at 22:20, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 28 Jul 2020 12:08:36 -0700 Tony Nguyen wrote:
> > This series contains updates to i40e driver only.
> >
> > Li RongQing removes binding affinity mask to a fixed CPU and sets
> > prefetch of Rx buffer page to occur conditionally.
> >
> > Björn provides AF_XDP performance improvements by not prefetching HW
> > descriptors, using 16 byte descriptors, increasing budget for AF_XDP
> > receive, and moving buffer allocation out of Rx processing loop.
>
> My comment on patch #2 is really a nit, but for patch 5 I think we
> should consider carefully a common path rather than "tweak" the drivers
> like this.

Yup, I agree that tweaks like this should be avoided, and I said that
I'll address it in a follow up. However, I was under the impression
that this series would still be pulled (discussed in patch 5), but I
can't find it in the tree.

Thanks,
Björn