netdev - Re: [PATCH v2 net-next 3/3] ionic: separate interrupt for Tx and Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200730174442.6bb9e652@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 30 Jul 2020 17:44:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v2 net-next 3/3] ionic: separate interrupt for Tx and Rx

On Thu, 30 Jul 2020 17:00:58 -0700 Shannon Nelson wrote:
> +	max_cnt = lif->ionic->ntxqs_per_lif;
> +	if (ch->combined_count) {
> +		if (!test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) &&
> +		    (ch->combined_count == lif->nxqs)) {
> +			netdev_info(netdev, "No change a\n");
> +			return 0;
> +		}
> +
> +		netdev_info(netdev, "Changing queue count from %d to %d\n",
> +			    lif->nxqs, ch->combined_count);
> +	} else {
> +		max_cnt /= 2;
> +		if (test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) &&
> +		    (ch->rx_count == lif->nxqs)) {
> +			netdev_info(netdev, "No change b\n");
> +			return 0;
> +		}
> +
> +		netdev_info(netdev, "Changing queue count from %d to %d\n",
> +			    lif->nxqs, ch->rx_count);
> +	}

A little verbose there with the printin' but overall looks reasonable:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>