netdev - Re: [PATCH net] net: ll_temac: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Jul 2020 17:44:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wanghai38@...wei.com
Cc:     kuba@...nel.org, michal.simek@...inx.com, esben@...nix.com,
        timur@...nel.org, f.fainelli@...il.com, weiyongjun1@...wei.com,
        hkallweit1@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ll_temac: Use
 devm_platform_ioremap_resource_byname()

From: Wang Hai <wanghai38@...wei.com>
Date: Thu, 30 Jul 2020 15:24:19 +0800

> platform_get_resource() may fail and return NULL, so we had better
> check its return value to avoid a NULL pointer dereference a bit later
> in the code. Fix it to use devm_platform_ioremap_resource_byname()
> instead of calling platform_get_resource_byname() and devm_ioremap().
> 
> Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

Applied to net-next.