lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 31 Jul 2020 08:56:35 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>,
        <chiqijun@...wei.com>
Subject: Re: [PATCH net-next v1 1/2] hinic: add generating mailbox random
 index support

On 2020/7/31 0:25, Jakub Kicinski wrote:
> On Thu, 30 Jul 2020 16:37:15 +0800 Luo bin wrote:
>> +bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func,
>> +			     u8 *header)
> 
> This set seems to add new W=1 C=1 warnings:
> 
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:572:6: warning: no previous prototype for ‘check_vf_mbox_random_id’ [-Wmissing-prototypes]
>   572 | bool check_vf_mbox_random_id(struct hinic_mbox_func_to_func *func_to_func,
>       |      ^~~~~~~~~~~~~~~~~~~~~~~
> 
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:1352:28: warning: symbol 'hw_cmd_support_vf' was not declared. Should it be static?
> .
> 
Will fix. Thanks for your review.

Powered by blists - more mailing lists