lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jul 2020 02:05:32 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org, netdev@...r.kernel.org, ast@...com Cc: andrii.nakryiko@...il.com, kernel-team@...com, Song Liu <songliubraving@...com> Subject: Re: [PATCH bpf-next] libbpf: make destructors more robust by handling ERR_PTR(err) cases On 7/30/20 1:21 AM, Andrii Nakryiko wrote: > Most of libbpf "constructors" on failure return ERR_PTR(err) result encoded as > a pointer. It's a common mistake to eventually pass such malformed pointers > into xxx__destroy()/xxx__free() "destructors". So instead of fixing up > clean up code in selftests and user programs, handle such error pointers in > destructors themselves. This works beautifully for NULL pointers passed to > destructors, so might as well just work for error pointers. > > Suggested-by: Song Liu <songliubraving@...com> > Signed-off-by: Andrii Nakryiko <andriin@...com> Applied, thanks!
Powered by blists - more mailing lists