netdev - Re: [PATCH 1/2] net: phy: Add fwnode helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202008011625.PhuVrV6D%lkp@intel.com>
Date:   Sat, 1 Aug 2020 16:10:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vikas Singh <vikas.singh@...esoftware.com>, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, calvin.johnson@....nxp.com,
        kuldip.dwivedi@...esoftware.com, madalin.bucur@....nxp.com,
        vikas.singh@....com, Vikas Singh <vikas.singh@...esoftware.com>
Subject: Re: [PATCH 1/2] net: phy: Add fwnode helper functions

Hi Vikas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc7 next-20200731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vikas-Singh/Add-fwnode-helper-functions-to-MDIO-bus-driver/20200728-201610
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 92ed301919932f777713b9172e525674157e983d
config: h8300-randconfig-s031-20200731 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-115-g5fc204f2-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   h8300-linux-ld: drivers/net/phy/mdio_bus.o: in function `fwnode_phy_connect':
>> drivers/net/phy/mdio_bus.c:102: undefined reference to `phy_connect_direct'

vim +102 drivers/net/phy/mdio_bus.c

    76	
    77	/**
    78	 * fwnode_phy_connect - Connect to the phy described in the device tree
    79	 * @dev: pointer to net_device claiming the phy
    80	 * @phy_fwnode: Pointer to fwnode for the PHY
    81	 * @hndlr: Link state callback for the network device
    82	 * @flags: flags to pass to the PHY
    83	 * @iface: PHY data interface type
    84	 *
    85	 * If successful, returns a pointer to the phy_device with the embedded
    86	 * struct device refcount incremented by one, or NULL on failure. The
    87	 * refcount must be dropped by calling phy_disconnect() or phy_detach().
    88	 */
    89	struct phy_device *fwnode_phy_connect(
    90			struct net_device *dev, struct fwnode_handle *phy_fwnode,
    91			void (*hndlr)(struct net_device *), u32 flags, u32 iface)
    92	{
    93		struct phy_device *phy_dev;
    94	
    95		phy_dev = fwnode_phy_find_device(phy_fwnode);
    96		if (!phy_dev)
    97			return NULL;
    98	
    99		phy_dev->dev_flags = flags;
   100	
   101		/* If in case we fail to attach to PHY,then phy_dev must be NULL */
 > 102		if (phy_connect_direct(dev, phy_dev, hndlr, iface))
   103			return NULL;
   104	
   105		return phy_dev;
   106	}
   107	EXPORT_SYMBOL(fwnode_phy_connect);
   108	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25209 bytes)