netdev - Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200801212202.7e4f3be2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 1 Aug 2020 21:22:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Cc:     Ganji Aravind <ganji.aravind@...lsio.com>, netdev@...r.kernel.org,
        davem@...emloft.net, vishal@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: Add support to flash firmware config
 image

On Sat, 1 Aug 2020 02:47:38 +0530 Rahul Lakkireddy wrote:
> I thought /lib/firmware is where firmware related files need to be
> placed and ethtool --flash needs to be used to program them to
> their respective locations on adapter's flash.

Our goal is to provide solid, common interfaces for Linux users to rely
on. Not give way to vendor specific "solutions" like uploading ini files
to perform device configuration.

> Note that we don't have devlink support in our driver yet. And,
> we're a bit confused here on why this already existing ethtool
> feature needs to be duplicated to devlink.

To be clear - I'm suggesting the creation of a more targeted APIs 
to control the settings you have encoded _inside_ the ini file. 
Not a new interface for an whole sale config upload.

Worst case scenario - if the settings are really device specific 
you can try to use devlink device parameters.