netdev - Re: [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200803223943.GA279188@PWN>
Date:   Mon, 3 Aug 2020 18:39:43 -0400
From:   Peilin Ye <yepeilin.cs@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     pshelar@....org, kuba@...nel.org, dan.carpenter@...cle.com,
        arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent
 kernel-infoleak in ovs_ct_put_key()

On Mon, Aug 03, 2020 at 03:10:38PM -0700, David Miller wrote:
> From: Peilin Ye <yepeilin.cs@...il.com>
> Date: Fri, 31 Jul 2020 00:48:38 -0400
> 
> > ovs_ct_put_key() is potentially copying uninitialized kernel stack memory
> > into socket buffers, since the compiler may leave a 3-byte hole at the end
> > of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix
> > it by initializing `orig` with memset().
> > 
> > Cc: stable@...r.kernel.org
> 
> Please don't CC: stable for networking fixes.

Sorry, I didn't know about that.

> > Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to sw_flow_key.")
> > Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Peilin Ye <yepeilin.cs@...il.com>
> 
> Applied and queued up for -stable, thank you.

Thank you for reviewing the patch!

Peilin Ye