lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 03 Aug 2020 15:42:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     romieu@...zoreil.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] via-velocity: Add missing KERN_<LEVEL> where needed

From: Joe Perches <joe@...ches.com>
Date: Sat, 01 Aug 2020 08:51:03 -0700

> Link status is emitted on multiple lines as it does not use
> KERN_CONT.
> 
> Coalesce the multi-part logging into a single line output and
> add missing KERN_<LEVEL> to a couple logging calls.
> 
> This also reduces object size.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

The real problem is the whole VELOCITY_PRT() private debug log
control business this driver is doing.

It should be using the standard netdev logging level infrastructure.

> +			VELOCITY_PRT(MSG_LEVEL_INFO, KERN_INFO "set Velocity to forced full mode\n");

You can't tell me that this "KERN_INFO blah blah blah" is really
something we should add more of these days, right?

If you're going to improve this driver's logging code please do
so by having it use the standard interfaces.

Thanks.

Powered by blists - more mailing lists