netdev - Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7a03137-b3f8-de21-2a05-95f019d63309@intel.com>
Date:   Mon, 3 Aug 2020 16:30:42 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [iproute2-next v2 5/5] devlink: support setting the overwrite
 mask



On 8/3/2020 8:53 AM, David Ahern wrote:
> On 7/31/20 6:21 PM, Jacob Keller wrote:
>> Add support for specifying the overwrite sections to allow in the flash
>> update command. This is done by adding a new "overwrite" option which
>> can take either "settings" or "identifiers" passing the overwrite mode
>> multiple times will combine the fields using bitwise-OR.
>>
>> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
>> ---
>>  devlink/devlink.c | 37 +++++++++++++++++++++++++++++++++++--
>>  1 file changed, 35 insertions(+), 2 deletions(-)
>>
> 
> 5/5? I only see 2 - 4/5 and 5/5. Please re-send against latest
> iproute2-next.
> 

Slightly unrelated: but the recent change to using a bitfield32 results
in a "GENMASK is undefined".. I'm not sure what the proper way to fix
this is, since we'd like to still use GENMASK to define the supported
bitfields. I guess we need to pull in more headers? Or define something
in include/utils.h?

Thanks,
Jake