netdev - Re: [PATCH bpf] selftests/bpf: prevent runqslower from racing on building bpftool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJPqWKS7-4f2G=-h2D1OwLZg1C1SRggXuYXg0rEg9JCBg@mail.gmail.com>
Date:   Thu, 6 Aug 2020 16:38:27 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] selftests/bpf: prevent runqslower from racing on
 building bpftool

On Wed, Aug 5, 2020 at 11:27 PM John Fastabend <john.fastabend@...il.com> wrote:
>
> Andrii Nakryiko wrote:
> > runqslower's Makefile is building/installing bpftool into
> > $(OUTPUT)/sbin/bpftool, which coincides with $(DEFAULT_BPFTOOL). In practice
> > this means that often when building selftests from scratch (after `make
> > clean`), selftests are racing with runqslower to simultaneously build bpftool
> > and one of the two processes fail due to file being busy. Prevent this race by
> > explicitly order-depending on $(BPFTOOL_DEFAULT).
> >
> > Fixes: a2c9652f751e ("selftests: Refactor build to remove tools/lib/bpf from include path")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> > ---
>
> Acked-by: John Fastabend <john.fastabend@...il.com>

Applied. Thanks