netdev - RE: [PATCH bpf] selftests/bpf: prevent runqslower from racing on building bpftool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f2ba2b6a22ac_291f2b27e574e5b885@john-XPS-13-9370.notmuch>
Date:   Wed, 05 Aug 2020 23:27:02 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: RE: [PATCH bpf] selftests/bpf: prevent runqslower from racing on
 building bpftool

Andrii Nakryiko wrote:
> runqslower's Makefile is building/installing bpftool into
> $(OUTPUT)/sbin/bpftool, which coincides with $(DEFAULT_BPFTOOL). In practice
> this means that often when building selftests from scratch (after `make
> clean`), selftests are racing with runqslower to simultaneously build bpftool
> and one of the two processes fail due to file being busy. Prevent this race by
> explicitly order-depending on $(BPFTOOL_DEFAULT).
> 
> Fixes: a2c9652f751e ("selftests: Refactor build to remove tools/lib/bpf from include path")
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>