netdev - RE: [PATCH bpf-next] libbf: fix uninitialized pointer at btf__parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Aug 2020 23:21:40 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     "Daniel T. Lee" <danieltimlee@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andriin@...com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: RE: [PATCH bpf-next] libbf: fix uninitialized pointer at
 btf__parse_raw()

Daniel T. Lee wrote:
> Recently, from commit 94a1fedd63ed ("libbpf: Add btf__parse_raw() and
> generic btf__parse() APIs"), new API has been added to libbpf that
> allows to parse BTF from raw data file (btf__parse_raw()).
> 
> The commit derives build failure of samples/bpf due to improper access
> of uninitialized pointer at btf_parse_raw().
> 
>     btf.c: In function btf__parse_raw:
>     btf.c:625:28: error: btf may be used uninitialized in this function
>       625 |  return err ? ERR_PTR(err) : btf;
>           |         ~~~~~~~~~~~~~~~~~~~^~~~~
> 
> This commit fixes the build failure of samples/bpf by adding code of
> initializing btf pointer as NULL.
> 
> Fixes: 94a1fedd63ed ("libbpf: Add btf__parse_raw() and generic btf__parse() APIs")
> Signed-off-by: Daniel T. Lee <danieltimlee@...il.com>
> ---

Unless errno is zero this should be ok in practice, but I guess compiler
wont know that.

Acked-by: John Fastabend <john.fastabend@...il.com>