netdev - Re: [PATCH bpf] bpf: add missing return to resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLnKo+V9tR+RmtwChqT8m211iDfHUjoZ=3psL_Brov6aA@mail.gmail.com>
Date:   Thu, 6 Aug 2020 16:52:18 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf] bpf: add missing return to resolve_btfids

On Thu, Aug 6, 2020 at 11:22 AM <sdf@...gle.com> wrote:
>
> On 08/06, Stanislav Fomichev wrote:
> > int sets_patch(struct object *obj) doesn't have a 'return 0' at the end.
>
> > Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> > ---
> >   tools/bpf/resolve_btfids/main.c | 1 +
> >   1 file changed, 1 insertion(+)
>
> > diff --git a/tools/bpf/resolve_btfids/main.c
> > b/tools/bpf/resolve_btfids/main.c
> > index 52d883325a23..4d9ecb975862 100644
> > --- a/tools/bpf/resolve_btfids/main.c
> > +++ b/tools/bpf/resolve_btfids/main.c
> > @@ -566,6 +566,7 @@ static int sets_patch(struct object *obj)
>
> >               next = rb_next(next);
> >       }
> > +     return 0;
> >   }
>
> >   static int symbols_patch(struct object *obj)
> > --
> > 2.28.0.236.gb10cc79966-goog
>
> Sorry, forgot:
>
> Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in
> ELF object")

Applied. Thanks