netdev - Re: [PATCH bpf] bpf: remove inline from bpf_do_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Aug 2020 16:55:01 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf] bpf: remove inline from bpf_do_trace_printk

On Thu, Aug 6, 2020 at 11:26 AM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> I get the following error during compilation on my side:
> kernel/trace/bpf_trace.c: In function 'bpf_do_trace_printk':
> kernel/trace/bpf_trace.c:386:34: error: function 'bpf_do_trace_printk' can never be inlined because it uses variable argument lists
>  static inline __printf(1, 0) int bpf_do_trace_printk(const char *fmt, ...)
>                                   ^
>
> Fixes: ac5a72ea5c89 ("bpf: Use dedicated bpf_trace_printk event instead of trace_printk()")
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied. Thanks