[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 07 Aug 2020 17:41:04 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: r.czerwinski@...gutronix.de
Cc: borisp@...lanox.com, aviadye@...lanox.com,
john.fastabend@...il.com, daniel@...earbox.net, kuba@...nel.org,
kernel@...gutronix.de, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg
From: Rouven Czerwinski <r.czerwinski@...gutronix.de>
Date: Thu, 6 Aug 2020 08:49:06 +0200
> Trying to use ktls on a system with 32-bit userspace and 64-bit kernel
> results in a EOPNOTSUPP message during sendmsg:
>
> setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0
> sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation not supported)
>
> The tls_sw implementation does strict flag checking and does not allow
> the MSG_CMSG_COMPAT flag, which is set if the message comes in through
> the compat syscall.
>
> This patch adds MSG_CMSG_COMPAT to the flag check to allow the usage of
> the TLS SW implementation on systems using the compat syscall path.
>
> Note that the same check is present in the sendmsg path for the TLS
> device implementation, however the flag hasn't been added there for lack
> of testing hardware.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@...gutronix.de>
I'll apply this, thank you.
Powered by blists - more mailing lists