lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 07 Aug 2020 17:26:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: fix warn at shutdown time for unaccepted
 msk sockets

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  7 Aug 2020 19:03:53 +0200

> With commit b93df08ccda3 ("mptcp: explicitly track the fully
> established status"), the status of unaccepted mptcp closed in
> mptcp_sock_destruct() changes from TCP_SYN_RECV to TCP_ESTABLISHED.
> 
> As a result mptcp_sock_destruct() does not perform the proper
> cleanup and inet_sock_destruct() will later emit a warn.
> 
> Address the issue updating the condition tested in mptcp_sock_destruct().
> Also update the related comment.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/66
> Reported-and-tested-by: Christoph Paasch <cpaasch@...le.com>
> Fixes: b93df08ccda3 ("mptcp: explicitly track the fully established status")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Also applied, thank you.

Powered by blists - more mailing lists