netdev - Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200809002947.GA92634@roeck-us.net>
Date:   Sat, 8 Aug 2020 17:29:47 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Edward Cree <ecree@...arflare.com>
Cc:     linux-net-drivers@...arflare.com, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at
 probe time

On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:
> Several parts of the EF100 architecture are parameterised (to allow
>  varying capabilities on FPGAs according to resource constraints), and
>  these parameters are exposed to the driver through a TLV-encoded
>  region of the BAR.
> For the most part we either don't care about these values at all or
>  just need to sanity-check them against the driver's assumptions, but
>  there are a number of TSO limits which we record so that we will be
>  able to check against them in the TX path when handling GSO skbs.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  drivers/net/ethernet/sfc/ef100_nic.c | 216 +++++++++++++++++++++++++++
>  drivers/net/ethernet/sfc/ef100_nic.h |   4 +
>  2 files changed, 220 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c
> index c2bec2bdbc1f..9b5e4b42fe51 100644
> --- a/drivers/net/ethernet/sfc/ef100_nic.c
> +++ b/drivers/net/ethernet/sfc/ef100_nic.c

[ ... ]

> +		if (EFX_MIN_DMAQ_SIZE % reader->value) {

This is a 64-bit operation (value is 64 bit). Result on 32-bit builds:

ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined!

Guenter