netdev - Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcb8dba7-d259-4aa3-96d5-066b725ae84b@solarflare.com>
Date:   Mon, 10 Aug 2020 09:15:20 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at
 probe time

On 09/08/2020 01:29, Guenter Roeck wrote:
> On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:
>> +		if (EFX_MIN_DMAQ_SIZE % reader->value) {
> This is a 64-bit operation (value is 64 bit). Result on 32-bit builds:
>
> ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined!
>
> Guenter
Yep, kbuild robot already spotted this, and I'm trying to figureout
 the cleanest way to deal with it.
See https://lore.kernel.org/netdev/487d9159-41f8-2757-2e93-01426a527fb5@solarflare.com/
Any advice would be welcome...

-ed