netdev - Re: [PATCH ethtool 2/7] ioctl: check presence of eeprom length argument properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200810141222.GE2123435@lunn.ch>
Date:   Mon, 10 Aug 2020 16:12:22 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/7] ioctl: check presence of eeprom length
 argument properly

On Sun, Aug 09, 2020 at 11:24:22PM +0200, Michal Kubecek wrote:
> In do_geeprom(), do_seprom() and do_getmodule(), check if user used
> "length" command line argument is done by setting the value to -1 before
> parsing and checking if it changed. This is quite ugly and also causes
> compiler warnings as the variable is u32.
> 
> Use proper "seen" flag to let parser tell us if the argument was used.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew